[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 02 Mar 2008 21:09:26 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: wangchen@...fujitsu.com
Cc: netdev@...r.kernel.org, chas3@...rs.sourceforge.net
Subject: Re: take#2: [PATCH] [ATM]: Add error handling for proc_create fail
From: Wang Chen <wangchen@...fujitsu.com>
Date: Mon, 03 Mar 2008 10:44:33 +0800
> David Miller said the following on 2008-3-1 2:38:
> > This is not sufficient. If this fails you need to unregister
> > the ioctl and all of the other things that get registered
> > before this procfs registry runs.
> >
>
> When proc_create() fail, we return -ENOMEM.
>
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
Sigh....
I know you want to avoid all of the error handling unwind code, but
you can't do that in this situation. It's not valid to register the
ATM clip procfs file without first initializing the ATM clip neighbour
table, so moving it up like this isn't going to work.
They way you've done it, a user can open the procfs file and access
the datastructure before it's initialized properly.
Please, simply add the necessary unregister code and leave the procfs
initialization where it currently is.
I get the sense you really aren't reading this code carefully and
you're tossing these patches together as quickly as you can to just
get it done. Please don't do that, it wastes both my time and
your's.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists