[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 03 Mar 2008 12:21:10 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: xemul@...nvz.org
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.26][ARP]: Introduce the arp_hdr_len helper.
From: Pavel Emelyanov <xemul@...nvz.org>
Date: Mon, 03 Mar 2008 13:56:40 +0300
> There are some place, that calculate the ARP header length. These
> calculations are correct, but
> a) some operate with "magic" constants,
> b) enlarge the code length (sometimes at the cost of coding style),
> c) are not informative from the first glance.
>
> The proposal is to introduce a helper, that includes all the good
> sides of these calculations.
>
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
Looks good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists