netdev - [PATCH 0/2][PPPOL2TP]: Fix SMP oops in pppol2tp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 5 Mar 2008 23:20:27 GMT
From:	James Chapman <jchapman@...alix.com>
To:	netdev@...r.kernel.org
Cc:	jarkao2@...il.com
Subject: [PATCH 0/2][PPPOL2TP]: Fix SMP oops in pppol2tp driver

This patch set fixes some locking issues in the pppol2tp driver which
can cause a kernel crash on SMP boxes when hundreds of L2TP sessions
are created/deleted simultaneously (ISP environment).

There are 2 patches:-

   1. use softirq-safe spinlocks and don't take sk_dst_lock in the
      transmit path

   2. fix races in dequeueing skbs from a session's reorder queue.

There are still problems lurking somewhere in the driver that cause
the kernel to hang but this only happens under certain stress test
conditions. The fixes provided in this patch set fix fundamental
locking issues in the driver which have caused an oops in more than
one setup, hence this patch set is being pushed upstream now while we
continue to work on the kernel hang.

Signed-off-by: James Chapman <jchapman@...alix.com>

--

A previous version of this patch set used _irq variants of the lock
functions. A lengthy thread discussing it is archived at
http://marc.info/?l=linux-netdev&m=120272177622133&w=4

If the patches are accepted, can they also be pushed to the stable
2.6.23 and 2.6.24 trees?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html