netdev - Re: [E1000-devel] [PATCH 2/4] [RFC] e1000: make ioport free for supported devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 06 Mar 2008 11:35:17 -0800
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [E1000-devel] [PATCH 2/4] [RFC] e1000: make ioport free for	supported
 devices

Jeff Garzik wrote:
> Auke Kok wrote:
>> From: Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>
>>
>> Most e1000 devices do not need ioport access to function properly.
>> This is desirable for a few massive homed systems where ioport
>> resources become constrained.
>>
>> This patch is based on the code from Tomohiro Kusumi, heavily
>> modified to fit PCI API changes and e1000 driver changes.
>>
>> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> 
> I don't think you need pci_select_bars()?  It should just be 
> pci_enable_device_mem() in both paths AFAICS...

honestly I don't know :) - I'll look into it. if that's the case then the patch
will change significantly.

thanks,

Auke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html