netdev - Re: [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module with module_init&module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Mar 2008 16:00:10 -0800
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	jeff@...zik.org
CC:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	jkschind@...il.com, alan@...rguk.ukuu.org.uk
Subject: Re: [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module
 with module_init&module_exit

akpm@...ux-foundation.org wrote:
> From: Jon Schindler <jkschind@...il.com>
> 
> Replace init_module and cleanup_module with static functions and
> module_init/module_exit.
> 
> Signed-off-by: Jon Schindler <jkschind@...il.com>
> Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

something went wrong here as this patch already appears to be in jeff's upstream
tree as commit 8724c2de65fe527f5b7aa662fcb8573fb8cd02f2, but breaks compile.

with CONFIG_NE2K_PCI=m:

  CC [M]  drivers/net/8390.o
drivers/net/8390.c: In function '__inittest':
drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this
function)
drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
drivers/net/8390.c:60: error: for each function it appears in.)
make[2]: *** [drivers/net/8390.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2


reverting the patch fixes the issue, but better would be to fix.

Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
Cc: Jon Schindler <jkschind@...il.com>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@...ux-foundation.org>

---
diff --git a/drivers/net/8390.c b/drivers/net/8390.c
index 0ed41a3..a499e86 100644
--- a/drivers/net/8390.c
+++ b/drivers/net/8390.c
@@ -57,7 +57,7 @@ static void __exit ns8390_module_exit(void)
 {
 }

-module_init(ns8390_init_module);
+module_init(ns8390_module_init);
 module_exit(ns8390_module_exit);
 #endif /* MODULE */
 MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html