netdev - Re: [PATCH] ethtool: command line support for lro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2008 18:50:47 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Kieran Mansley <kmansley@...arflare.com>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: command line support for lro

Stephen Hemminger wrote:
> On Mon, 10 Mar 2008 18:07:07 +0000
> Ben Hutchings <bhutchings@...arflare.com> wrote:
> 
> > Stephen Hemminger wrote:
<snip>
> > > @@ -1559,12 +1566,20 @@ static int do_goffload(int fd, struct ifreq *ifr)
> > >  		allfail = 0;
> > >  	}
> > >  
> > > +	eval.cmd = ETHTOOL_GFLAGS;
> > > +	ifr->ifr_data = (caddr_t)&eval;
> > > +	err = ioctl(fd, SIOCETHTOOL, ifr);
> > > +	if (!err) {
> > > +		lro = eval.data & ETH_FLAG_LRO;
> > > +		allfail = 0;
> > > +	}
> > > +
> > 
> > To be consistent, this should print a specific error if the ioctl
> > fails.
> 
> No, since most hardware won't support LRO or the flags, it makes sense not
> to complain when fetching the value.
<snip>

Many of the other offloads have the same issue, particularly when
using a new ethtool with an old kernel.  Maybe we should not print an
error message if the error is EOPNOTSUPP or EPERM (unknown commands
are assumed to require admin capability).  But that's a separate
change and again it's not specific to LRO.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html