netdev - Re: [PATCH 13/13] r8169: more phy init for the 8168

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Mar 2008 14:20:10 +0000
From:	Glen Gray <glen.gray@...cor.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 13/13] r8169: more phy init for the 8168

Hey Francois,

Spent some time on this yesterday and today, managed to get a Fedora 8  
install up and running on the hardware. This is using the 2.6.24.3  
kernel from Fedora.

Unfortunately it's still got exactly the same problem, specifically,  
the device comes up and doesn't see any SAP announcements. It's  
getting it's IP address via DHCP.

cat /proc/net/igmp also shows it as V3. If I force it to version 2 it  
still doesn't seem to detect anything.

You suggested the patch below back in October and I didn't get any  
time to work on it. I've just checked the source for the Fedora  
2.6.24.3 kernel and it doesn't have the blow in there, so I'm going to  
patch this against the kernel and see if it helps in anyway.

If you've any further suggestions then please pass them on.

Appropriate data from dmesg........
r8169 Gigabit Ethernet driver 2.2LK-NAPI loaded
eth0: RTL8169sc/8110sc at 0xdc868000, 00:05:6b:40:2c:be, XID 18000000  
IRQ 18
r8169: eth0: link up

Kind Regards,
--
Glen Gray <glen.gray@...cor.com>         Digital Depot, Thomas Street
Senior Software Engineer                            Dublin 8, Ireland
Lincor Solutions Ltd.                          Ph: +353 (0) 1 4893682

On 31 Oct 2007, at 21:10, Francois Romieu wrote:

> Glen Gray <glen.gray@...cor.com> :
> [...]
>> However, we do have a few hundred units out in the field now that
>> we'll need to support going forward. So I'm keeping an eye on this
>> issue's progress.
>
> Can you try 2.6.13 + the patch below if you have some time left ?
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index b94fa7e..1191802 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -1367,8 +1367,10 @@ static void rtl8169_phy_timer(unsigned long  
> __opaque)
> 		goto out_mod_timer;
> 	}
>
> -	if (tp->link_ok(ioaddr))
> +	if (tp->link_ok(ioaddr)) {
> +		dev->set_multicast_list(dev);
> 		goto out_unlock;
> +	}
>
> 	if (netif_msg_link(tp))
> 		printk(KERN_WARNING "%s: PHY reset until link up\n", dev->name);
> -- 
> Ueimor

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html