netdev - Re: [PATCH 6/6] drivers/net/e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2008 14:03:58 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Joe Perches <joe@...ches.com>
CC:	Jeff Garzik <jgarzik@...ox.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 6/6] drivers/net/e1000 - Convert int32_t to s32

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/net/e1000/e1000_hw.c   |  486 ++++++++++++++++++++--------------------
>  drivers/net/e1000/e1000_hw.h   |   58 +++---
>  drivers/net/e1000/e1000_main.c |    4 +-
>  3 files changed, 274 insertions(+), 274 deletions(-)


can you do all the 4 conversions in a single patch? most of these hunks are now
quadrupled into patches (they all touch the same parts of the files mostly), and
that doesn't improve git-blame output nor reviewability.

so just one patch for ixgb and one patch for e1000 should suffice, instead of 4
for each driver :)

thanks Joe

Auke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html