netdev - [PATCH RFT] b44: Truncate PHY address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 22 Mar 2008 01:24:20 +0100
From:	Michael Buesch <mb@...sch.de>
To:	agb@...nwrt.org
Cc:	Gary Zambrano <zambrano@...adcom.com>, netdev@...r.kernel.org
Subject: [PATCH RFT] b44: Truncate PHY address

Some ROMs on embedded devices store incorrect values for
the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it.

Signed-off-by: Michael Buesch <mb@...sch.de>

---

This patch is untested and needs some testing before it
can go upstream, but I think the chance of introducing bugs
with this is almost zero, as the PHY address register really is
only 5 bits long. So this will do The Right Thing (tm) in any case.
Please report result of the testing back to me. I will also run some
tests later and then submit the patch for inclusion.

Index: wireless-testing/drivers/net/b44.c
===================================================================
--- wireless-testing.orig/drivers/net/b44.c	2008-02-16 19:08:12.000000000 +0100
+++ wireless-testing/drivers/net/b44.c	2008-03-22 01:13:21.000000000 +0100
@@ -2082,6 +2082,11 @@ static int __devinit b44_get_invariants(
 		addr = sdev->bus->sprom.et0mac;
 		bp->phy_addr = sdev->bus->sprom.et0phyaddr;
 	}
+	/* Some ROMs have buggy PHY addresses with the high
+	 * bits set (sign extension?). Truncate them to a
+	 * valid PHY address. */
+	bp->phy_addr &= 0x1F;
+
 	memcpy(bp->dev->dev_addr, addr, 6);

 	if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html