lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Mar 2008 17:52:12 -0700 (PDT) From: David Miller <davem@...emloft.net> To: vda.linux@...glemail.com Cc: ilpo.jarvinen@...sinki.fi, akpm@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, acme@...hat.com Subject: Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot From: Denys Vlasenko <vda.linux@...glemail.com> Date: Fri, 28 Mar 2008 00:36:59 +0100 > Can you add a comment which explains the intent? > > +struct sk_buff *dev_alloc_skb(unsigned int length) > +{ > + /* There is more code here than it seems: > + * __dev_alloc_skb is an inline */ > + return __dev_alloc_skb(length, GFP_ATOMIC); > +} > +EXPORT_SYMBOL(dev_alloc_skb); I've applied his patch already, if you want this comment please submit the patch to add it and also please use the correct formatting of the comment. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists