netdev - Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2008 16:58:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, chas@....nrl.navy.mil, jeff@...zik.org
Subject: Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized
 var warning

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Fri, 28 Mar 2008 16:54:37 -0700

> > diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
> > index 47c57a4..98099f5 100644
> > --- a/drivers/atm/firestream.c
> > +++ b/drivers/atm/firestream.c
> > @@ -978,6 +978,7 @@ static int fs_open(struct atm_vcc *atm_vcc)
> >  		/* Docs are vague about this atm_hdr field. By the way, the FS
> >  		 * chip makes odd errors if lower bits are set.... -- REW */
> >  		tc->atm_hdr =  (vpi << 20) | (vci << 4); 
> > +		tmc0 = 0;
> >  		{
> >  			int pcr = atm_pcr_goal (txtp);
> 
> Whereas the reader doesn't know why that unneeded initialisation is there.

git show $(git blame drivers/atm/firestream.c | grep "tmc0 = 0" | \
	   awk ' { print $1 } ')
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html