netdev - Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2008 16:57:32 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	chas@....nrl.navy.mil, jeff@...zik.org
Subject: Re: [patch 1/4] drivers/atm/firestream.c: suppress uninitialized var warning

On Fri, Mar 28, 2008 at 05:39:46PM -0700, Andrew Morton wrote:
> On Fri, 28 Mar 2008 17:35:23 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
> 
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > Date: Fri, 28 Mar 2008 17:11:28 -0700
> > 
> > > Plus uninitialized_var() gives us something to grep for and
> > > experiment with if/when future gcc's get smarter.
> > 
> > That's sounds like a great investment of your time.
> > 
> > I guess there aren't any more interesting things to work
> > on, nor bugs to fix.
> 
> So you're all outa reasons.

Not really...  "we know better, gcc must STFU" applies _now_.  And gcc getting
smarter is not the only way it can become false - code change in the function
can create real uninitialized use.  gcc tends to change the warning on that,
but not if it's told to STFU in either way.

IOW, my preference would be to leave the warning as is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html