lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Apr 2008 23:29:00 +1100 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Stefan Roese <sr@...x.de> Cc: netdev@...r.kernel.org, linuxppc-dev@...abs.org Subject: Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL rx-channel handling On Thu, 2008-04-03 at 13:45 +0200, Stefan Roese wrote: > On some 4xx PPC's (e.g. 460EX/GT), the rx channel number is a multiple > of 8 (e.g. 8 for EMAC1, 16 for EMAC2), but enabling in MAL_RXCASR needs > the divided by 8 value for the bitmask. Sounds ok, but I wonder if we ever have a MAL with more than 8 chans, do we need to make this shift conditional to some device tree prop ? > Signed-off-by: Stefan Roese <sr@...x.de> > --- > drivers/net/ibm_newemac/mal.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ibm_newemac/mal.c b/drivers/net/ibm_newemac/mal.c > index 6869f08..fb9c9eb 100644 > --- a/drivers/net/ibm_newemac/mal.c > +++ b/drivers/net/ibm_newemac/mal.c > @@ -136,6 +136,14 @@ void mal_enable_rx_channel(struct mal_instance *mal, int channel) > { > unsigned long flags; > > + /* > + * On some 4xx PPC's (e.g. 460EX/GT), the rx channel is a multiple > + * of 8, but enabling in MAL_RXCASR needs the divided by 8 value > + * for the bitmask > + */ > + if (!(channel % 8)) > + channel >>= 3; > + > spin_lock_irqsave(&mal->lock, flags); > > MAL_DBG(mal, "enable_rx(%d)" NL, channel); > @@ -148,6 +156,14 @@ void mal_enable_rx_channel(struct mal_instance *mal, int channel) > > void mal_disable_rx_channel(struct mal_instance *mal, int channel) > { > + /* > + * On some 4xx PPC's (e.g. 460EX/GT), the rx channel is a multiple > + * of 8, but enabling in MAL_RXCASR needs the divided by 8 value > + * for the bitmask > + */ > + if (!(channel % 8)) > + channel >>= 3; > + > set_mal_dcrn(mal, MAL_RXCARR, MAL_CHAN_MASK(channel)); > > MAL_DBG(mal, "disable_rx(%d)" NL, channel); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists