lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Apr 2008 22:52:16 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Jeff Garzik <jgarzik@...ox.com> Cc: Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org, Cesar Eduardo Barros <cesarb@...arb.net>, tom@...rkbay.at Subject: Re: [PATCH] sc92031: sysfs link missing On Fri, 04 Apr 2008 01:46:05 -0400 Jeff Garzik <jgarzik@...ox.com> wrote: > Stephen Hemminger wrote: > > Add missing sysfs device association. Compile tested only -ENOHW. > > > > Signed-off-by: Stephen Hemminger <shemminger@...tta.com> > > > > > > --- a/drivers/net/sc92031.c 2008-04-02 09:34:35.000000000 -0700 > > +++ b/drivers/net/sc92031.c 2008-04-02 09:36:53.000000000 -0700 > > @@ -1446,6 +1446,7 @@ static int __devinit sc92031_probe(struc > > } > > > > pci_set_drvdata(pdev, dev); > > + SET_NETDEV_DEV(dev, &hw->pdev->dev); > > > > #if SC92031_USE_BAR == 0 > > dev->mem_start = pci_resource_start(pdev, SC92031_USE_BAR); > > applied > That's version 1. There was a super-optimised version 2: From: Stephen Hemminger <shemminger@...tta.com> Add missing sysfs device association. Compile tested only -ENOHW. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=10380 Signed-off-by: Stephen Hemminger <shemminger@...tta.com> Cc: Jeff Garzik <jgarzik@...ox.com> Cc: Cesar Eduardo Barros <cesarb@...arb.net> Cc: <tom@...rkbay.at> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- drivers/net/sc92031.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/net/sc92031.c~sc92031-sysfs-link-missing drivers/net/sc92031.c --- a/drivers/net/sc92031.c~sc92031-sysfs-link-missing +++ a/drivers/net/sc92031.c @@ -1446,6 +1446,7 @@ static int __devinit sc92031_probe(struc } pci_set_drvdata(pdev, dev); + SET_NETDEV_DEV(dev, &pdev->dev); #if SC92031_USE_BAR == 0 dev->mem_start = pci_resource_start(pdev, SC92031_USE_BAR); _ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists