netdev - Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Apr 2008 18:01:18 +0100
From:	Andy Furniss <lists@...yfurniss.entadsl.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	Corey Hickey <bugfood-ml@...ooh.org>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

Patrick McHardy wrote:
> Andy Furniss wrote:

>> I notice allot is short (16bits?) in sfq but see
>>
>> +struct tc_sfq_xstats
>> +{
>> +    __s32        allot;
>> +};
> 
> That doesn't matter, its promoted to a 32 bit value. But now
> that you mention it, the SFQ patch for iproute I submitted
> used a different type. Stephen has resynced it with the kernel
> in the mean time, but you might be using the broken version.

OK - I have the __s32 version in iproute git and in kernel 2.6.25-rc7.

I did have some hassle building iproute2 though, tc built OK once I 
removed ip from the build, so maybe I'll try again over the weekend from 
scratch just incase I messed something up.

Looking at the sfq code it seems that enqueue doesn't init/zero allot 
for a new flow unless it's the first and most of what I see fits with 
this. But rarely it doesn't look like that's all there is to it.

Andy.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html