netdev - Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Apr 2008 14:43:37 +0100
From:	Andy Furniss <lists@...yfurniss.entadsl.com>
To:	unlisted-recipients:; (no To-header on input)
CC:	Patrick McHardy <kaber@...sh.net>,
	Corey Hickey <bugfood-ml@...ooh.org>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

Andy Furniss wrote:
> Andy Furniss wrote:
> 
>> Looking at the sfq code it seems that enqueue doesn't init/zero allot 
>> for a new flow unless it's the first and most of what I see fits with 
>> this. 
> 
>> But rarely it doesn't look like that's all there is to it.
> 
> Actually it fits perfectly, so that is all there is to it. Dequeue 
> dequeues first then checks allot so even if the allot is stuck at -20345 
> or something the flow will still get 1 packet per round which is what 
> I've seen. I first thought it should have moved towards 0 like it does 
> when it starts too high.

Seems like this change fixes it for me, though I since noticed that 
requeue will need the same change as well.

--- sch_sfq.c.orig      2008-04-07 11:42:36.000000000 +0100
+++ sch_sfq.c   2008-04-07 11:46:41.000000000 +0100
@@ -317,6 +317,7 @@
                         q->next[x] = q->next[q->tail];
                         q->next[q->tail] = x;
                         q->tail = x;
+                       q->allot[x] = 0;
                 }
         }
         if (++sch->q.qlen <= q->limit) {


Andy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html