netdev - Re: [Devel] [PATCH 1/14][NETNS]: Introduce the net-subsys id generator.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Apr 2008 10:37:53 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Pavel Emelyanov" <xemul@...nvz.org>
Cc:	"Linux Netdev List" <netdev@...r.kernel.org>,
	"Linux Containers" <containers@...ts.osdl.org>,
	"Denis Lunev" <den@...nvz.org>,
	"Benjamin Thery" <benjamin.thery@...l.net>
Subject: Re: [Devel] [PATCH 1/14][NETNS]: Introduce the net-subsys id generator.

On Thu, Apr 10, 2008 at 8:01 AM, Pavel Emelyanov <xemul@...nvz.org> wrote:
>  +int register_pernet_gen_device(int *id, struct pernet_operations *ops)
>  +{
>  +       int error;
>  +       mutex_lock(&net_mutex);
>  +again:
>  +       error = ida_get_new_above(&net_generic_ids, 1, id);
>  +       if (error) {
>  +               if (error == -EAGAIN) {
>  +                       ida_pre_get(&net_generic_ids, GFP_KERNEL);
>  +                       goto again;
>  +               }

Shouldn't you handle non-EAGAIN errors here?

Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html