netdev - Re: Re-queueing of skb in vlan_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2008 06:47:13 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	viro@...IV.linux.org.uk, Brian_Oostenbrink@...-sierra.com,
	linux-net@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Re-queueing of skb in vlan_skb_recv

David Miller wrote:
> From: Patrick McHardy <kaber@...sh.net>
> Date: Fri, 11 Apr 2008 15:02:06 +0200
> 
>> Al Viro wrote:
>>> Another possibility would be to allow ->func() of packet_type to return an
>>> skb for reprocessing...
 >>>
>> That should work fine for VLAN, but not for loopback since its
>> called on the TX path. I think I prefer Eric's suggested way
>> because it doesn't require to change all the other existing
>> packet_type users.
> 
> I think Al's idea is the most elegant proposed so far and we could do
> something similar on the TX side as well.
> 
> Yes, it means diddling with a lot of call sites, but we do that all
> the time and it's heaps better then these "check the stack space
> remaining" hacks being proposed.

Agreed on second thought, I guess I was just being lazy :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html