netdev - Re: [INET]: sk_reuse is valbool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Apr 2008 21:49:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	netdev@...r.kernel.org
Subject: Re: [INET]: sk_reuse is valbool

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Mon, 7 Apr 2008 16:01:33 +0100

> I found this while checking how DCCP handles duplicate bind operations;
> it seems it is a remainder of earlier code and now defunct.
> 
> -----------------------------------> Patch <---------------------------------------
> [INET]: sk_reuse is valbool
> 
> sk_reuse is declared as "unsigned char", but is set as type valbool in net/core/sock.c.
> There is no other place in net/ where sk->sk_reuse is set to a value > 1, so the test 
> "sk_reuse > 1" can not be true.
> 
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>

I'll apply this to net-2.6.26, thanks Gerrit.

I wonder what the history is of this thing.  Perhaps it was used
for an implementation of SO_REUSEPORT, or something like that,
which got removed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html