lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Apr 2008 17:05:30 +0400 From: Pavel Emelyanov <xemul@...nvz.org> To: Patrick McHardy <kaber@...sh.net> CC: David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH net-2.6.26 5/10][VLAN]: Add a net argument to proc init and cleanup calls. >> +++ b/net/8021q/vlan.c >> @@ -642,8 +642,14 @@ static int vlan_init_net(struct net *net) >> if (err < 0) >> goto err_assign; >> >> + err = vlan_proc_init(net); >> + if (err < 0) >> + goto err_proc; >> + >> return 0; >> >> +err_proc: >> + /* nothing */ > > What is going to clean up net_generic_assign above? This is not required. Net will be just destroyed after this function returns. >> @@ -693,8 +696,6 @@ static int __init vlan_proto_init(void) >> err3: >> unregister_netdevice_notifier(&vlan_notifier_block); >> err2: >> - vlan_proc_cleanup(); >> -err1: >> unregister_pernet_gen_device(vlan_net_id, &vlan_net_ops); >> err0: >> return err; > > This could be done nicer, not leaving holes in the numbering. Well, yes. Bu this patch is large enough without it. Can I make this in a separate patch? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists