netdev - Re: [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for dev->priv alignment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Apr 2008 02:17:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	xemul@...nvz.org, netdev@...r.kernel.org, shemminger@...tta.com,
	kaber@...sh.net
Subject: Re: [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for
 dev->priv alignment.

From: Jarek Poplawski <jarkao2@...il.com>
Date: Tue, 8 Apr 2008 09:22:53 +0000

> On Tue, Apr 08, 2008 at 12:42:27PM +0400, Pavel Emelyanov wrote:
> > Hmm, AFAIC, the net_device alignment is done earlier, while this one
> > makes sense in case the priv pointer alignment.
> 
> Hmm, one NETDEV_ALIGN_CONST is later used just for net_device alignment,
> and you could not fit this struct after "~NETDEV_ALIGN_CONST" without
> adding anything. So you should probably skip "~NETDEV_ALIGN_CONST" in
> this no priv case too?

The Linux NETDEV Patch Robot has determined that these other
NETDEV_ALIGN_CONST instances need to be retained, therefore
Pavel's patch will be applied to net-2.6.26.

*beep* *beep*

Thank you for your valuable feedback.

*beep* *beep*

Keep hacking.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html