netdev - Re: Why MLDv2 Report packet is freed ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Apr 2008 14:50:47 +0300
From:	"Ian Brown" <ianbrn@...il.com>
To:	"YOSHIFUJI Hideaki / 吉藤英明" 
	<yoshfuji@...ux-ipv6.org>
Cc:	netdev@...r.kernel.org
Subject: Re: Why MLDv2 Report packet is freed ?

Hello,

I am sorry, I tried to delve into the code and I not sure I can figure out this
point.
> MLD packets are handled in other place.

Can anybody please try to elaborate on this point: how
are MLD packets handled ? Shouldn't MLD packets be
handled by pim6sd daemon? I see handlers for accepting MLD (v1 and v2)
in pim6sd daemon;
And in case MLD packets  should be handled by pim6sd  - shouldn't the kernel
pass these MLD packets to the pim6sd daemon (by calling sock_queue_rcv_skb()
in ip6mr.c) ? As far as I can understand, these MLD packets are
dropped in icmpv6_rcv()., see my
former post ;

IB

On Tue, Apr 15, 2008 at 5:48 PM, YOSHIFUJI Hideaki / 吉藤英明
<yoshfuji@...ux-ipv6.org> wrote:
> In article <d0383f90804150623r2eb071fau200a67c6ce65a7e0@...l.gmail.com> (at Tue, 15 Apr 2008 16:23:33 +0300), "Ian Brown" <ianbrn@...il.com> says:
>
>  > Now, I don't understand something here:
>  > I had looked at icmpv6_rcv() in net/ipv6/icmp.c.
>  >
>  > I see that when the type of the ICMP packet is ICMPV6_MLD2_REPORT it
>  > is dropped (calling kfree_skb()).
>  >
>  > shouldn't it be handled and passed onward so that it will
>  > eventually reach the pim6sd daemon ? or is this
>  > only implemented currently for MLDV1 ?
>
>  In MLDv1, Report suppress other hosts' reports, but
>  On the other hand, in MLDv2, Reports does not suppress.
>  So, MLDv2 Report is useless for in-kernel MLD handler.
>
>  MLD packets are handled in other place.
>
>  --yoshfuji
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html