netdev - Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Apr 2008 14:45:58 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	Auke Kok <auke-jan.h.kok@...el.com>, jeff@...zik.org,
	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

Patrick McHardy wrote:
> Auke Kok wrote:
>> Fix TSO over VLAN's by propagating settings to our VLAN devices.
>>   
> 
>> @@ -378,8 +381,21 @@ static int e1000_set_tso(struct net_device
>> *netdev, u32 data)
>>      } else {
>>          netdev->features &= ~NETIF_F_TSO;
>>          netdev->features &= ~NETIF_F_TSO6;
>> +        /* disable TSO on all VLANs if they're present */
>> +        if (!adapter->vlgrp)
>> +            goto tso_out;
>> +        for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) {
>> +            v_netdev = vlan_group_get_device(adapter->vlgrp, i);
>> +            if (!v_netdev)
>> +                continue;
>> +
>> +            v_netdev->features &= ~NETIF_F_TSO;
>> +            v_netdev->features &= ~NETIF_F_TSO6;
>> +            vlan_group_set_device(adapter->vlgrp, i, v_netdev);
>>   
> 
> What exactly is this supposed to fix? If this simply wants
> to propagate feature changes, I think it should use
> netdev_feat_change and handle that within the VLAN code.

I asked PJ and got this reply:

//
VLAN devices didn't get the parent's feature flags on creation.  I went
to fix this in the kernel, people pushed back that some devices couldn't
support both VLAN tag insertion offload and TSO, so I didn't push the
issue.  I worked around the issue by copying the flags in the driver.
The downside is when we turn off TSO using ethtool, we need to remove
TSO from all VLAN devices, since the hardware segmenter is no longer
available if the parent device doesn't have it enabled as a feature.  We
were seeing stack-based panics with gso_segment(), which was corrected
by removing the TSO flag from all VLAN devices.

I can't seem to find netdev_feat_change anywhere in the kernel, or
variants of that name, so I'm not sure what Patrick is pointing us at.

-PJ
//

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html