netdev - Re: [PATCH 4/5] [E1000]: [VLAN] Turn off the HW vlan filter if promisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Apr 2008 10:48:19 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Joonwoo Park <joonwpark81@...il.com>
CC:	kaber@...sh.net, jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] [E1000]: [VLAN] Turn off the HW vlan filter if promisc

Joonwoo Park wrote:
> 2008/4/18, Kok, Auke <auke-jan.h.kok@...el.com>:
>> My logistical objection against this patch is that it adjusts only one/two drivers
>> to do something, but I don't see anything consistently in all the drivers at all
>> that suggest that this is the right thing to do at all. Either a mandate or
>> something suggesting that all drivers that do vlan filtering *should* do something
>>  specific in promiscuous mode.
> 
> It's true. We need to fix all the netdev which is VLAN_HW_FILTER capable IMHO.
> However I couldn't make patches for all of them since I don't have those HW :(

sigh, we really should not make e1000(e) guinea pigs - especially at this time.

is there someone who can actually test this for us? I'd be a lot happier if I had
some confidence that people who actually do use promisc/vlans give me a thumbs up.


Auke


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html