netdev - Re: [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for C10 server blades

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2008 12:46:11 -0700
From:	Matheos Worku <Matheos.Worku@....COM>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for C10
 server blades

David Miller wrote:
> From: Matheos Worku <matheos.worku@....com>
> Date: Wed, 23 Apr 2008 10:17:40 -0700
>
>   
>> @@ -3243,6 +3245,7 @@ struct niu {
>>  	struct timer_list		timer;
>>  	const struct niu_phy_ops	*phy_ops;
>>  	int				phy_addr;
>> +	int hotplug_phy_present;
>>  	struct niu_link_config		link_config;
>>  
>>  	struct work_struct		reset_task;
>>     
>
> Using a full integer for boolean state is wasteful, please
> just add another state flag to niu->flags
>   
Dave,
New patch attached.

Regards
Matheos

> Thank you.
>   


View attachment "goa.patch" of type "text/x-patch" (11088 bytes)