netdev - Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2008 01:08:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit
 kernels.

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
Date: Thu, 24 Apr 2008 17:02:57 +0900 (JST)

> +#ifdef __KERNEL__
> +struct __compat_sockaddr_storage {
> +	unsigned short  ss_family;
> +	char		__data[_K_SS_MAXSIZE - sizeof(unsigned short)];
> +} __attribute__ ((aligned(4)));
> +#endif

Should include <linux/compat.h>, use compat types, and be guarded
by CONFIG_COMPAT.  This goes for all such structures.

>     [IPV6] COMPAT: group_filter{}-getsockopt compat layer.
>     
>     Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

Where is ip6_mc_compat_msfget() header file declaration?

This following call casts the 5th argument to "struct group_filter"
but the argument type in the implementation is...

> +int ip6_mc_compat_msfget(struct sock *sk,
> +			 struct in6_addr *group,
> +			 u32 gf_interface, u32 gf_numsrc,
> +			 struct compat_group_filter __user *optval,
> +			 int __user *optlen)

"struct compat_group_filter".

You didn't catch this because you forgot to add the extern
prototype to the header file.  Actually, I wonder if you test
built this at all, as gcc should have warned about the lack of
extern declaration when compiling ipv6_sockglue.c

Thanks for doing this work, please make corrections and I also
look forward to your ipv4 side fixes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html