netdev - RE: [PATCH] ucc_geth: Don't use RX clock as TX clock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2008 19:07:56 +0800
From:	"Li Yang" <LeoLi@...escale.com>
To:	"Jeff Garzik" <jgarzik@...ox.com>
Cc:	"Joakim Tjernlund" <Joakim.Tjernlund@...nsmode.se>,
	"Netdev" <netdev@...r.kernel.org>,
	"Tabi Timur" <timur@...escale.com>
Subject: RE: [PATCH] ucc_geth: Don't use RX clock as TX clock.

> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@...nsmode.se] 
> Sent: Tuesday, April 29, 2008 7:04 PM
> To: Netdev; Li Yang; Tabi Timur
> Cc: Joakim Tjernlund
> Subject: [PATCH] ucc_geth: Don't use RX clock as TX clock.
> 
> Commit 9fb1e350e16164d56990dde036ae9c0a2fd3f634,
> ucc_geth: use rx-clock-name and tx-clock-name device tree 
> properties Introduced a typo that made the driver use the RX 
> clock as TX clock, causing massive TX errors.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>

Acked-by: Li Yang <leoli@...escale.com>

> ---
> 
> Resending as the first one got rejected du to missing commas.
> 
>  drivers/net/ucc_geth.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c 
> index 28431aa..2de153f 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -3907,7 +3907,7 @@ static int ucc_geth_probe(struct 
> of_device* ofdev, const struct of_device_id *ma
>  			return -EINVAL;
>  		}
>  	} else {
> -		prop = of_get_property(np, "rx-clock", NULL);
> +		prop = of_get_property(np, "tx-clock", NULL);
>  		if (!prop) {
>  			printk(KERN_ERR
>  				"ucc_geth: mising tx-clock-name 
> property\n");
> --
> 1.5.5.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html