netdev - Re: [RFC/RFT 4/4] mac80211: use multi-queue master netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 16:45:43 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Ron Rindjunsky <ron.rindjunsky@...el.com>,
	Tomas Winkler <tomasw@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [RFC/RFT 4/4] mac80211: use multi-queue master netdevice

Hi Ivo,

> Overall the rt2x00 changes are good, but I have a few suggestions :)

> >  	struct rt2x00_dev *rt2x00dev = hw->priv;
> >  	struct ieee80211_hdr *ieee80211hdr = (struct ieee80211_hdr *)skb->data;
> > -	enum data_queue_qid qid = mac80211_queue_to_qid(control->queue);
> > +	enum data_queue_qid qid = skb_get_queue_mapping(skb);
> >  	struct data_queue *queue;

> >  		if (rt2x00queue_available(queue) <= 1) {
> > -			ieee80211_stop_queue(rt2x00dev->hw, control->queue);
> > +			ieee80211_stop_queue(
> > +				rt2x00dev->hw, skb_get_queue_mapping(skb));
> 
> ieee80211_stop_queue(rt2x00dev->hw, qid);
> The result of skb_get_queue_mapping(skb) was already stored in the
> 'qid' variable at the start of the function. And since this is a 1-1 mapping
> from skb queue to rt2x00 queue, it is safe to use 'qid' directly in all instances.

Heh, good point, changed that. Will probably generate the same code
since get_queue_mapping is a static inline, but hey, much nicer to read
that way :)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)