netdev - Re: [PATCH 0/2] Disable forwarding of LRO skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 May 2008 19:37:16 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Kieran Mansley <kmansley@...arflare.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, davem@...emloft.net,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs

On Thu, May 01, 2008 at 12:18:08PM +0100, Kieran Mansley wrote:
>
> If I remember rightly it also gets upset when it comes to split the
> packet because the frag_list is already in use; it expects this not to
> be the case for GSO but it's valid for an LRO packet to do this I think.
> I don't think there's anything fundamentally difficult here, it's just
> that the code has never been written to cope.

Oh so LRO packets still preserve the original packet boundaries?
That's even easier.  We could just make the GSO output code detect
the presence of frag_list and fragment based on that.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html