lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 03 May 2008 20:57:32 -0700 (PDT) From: David Miller <davem@...emloft.net> To: johannes@...solutions.net Cc: netdev@...r.kernel.org Subject: Re: [PATCH] [NET] fix useless comment reference loop From: Johannes Berg <johannes@...solutions.net> Date: Sun, 04 May 2008 00:05:42 +0200 > include/linux/skbuff.h says: > /* These elements must be at the end, see alloc_skb() for details. */ > > net/core/skbuff.c says: > * See comment in sk_buff definition, just before the 'tail' member > > This patch contains my guess as to the actual reason rather than a > dead comment reference loop. > > Signed-off-by: Johannes Berg <johannes@...solutions.net> Patch applied, thanks. This is an example of why I'm personally a comment minimalist. They tend to rot, confuse people, and often just duplicate what is obvious from the code (although not in this case). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists