[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 05 May 2008 12:37:03 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: pcnet32@...izon.net
Cc: netdev@...r.kernel.org, xemul@...nvz.org
Subject: Re: [PATCH 1/2][ATM]: Do not free already unregistered net device.
From: Don Fry <pcnet32@...izon.net>
Date: Mon, 05 May 2008 09:44:40 -0700
> I do not understand why this change was accepted. All of the network
> drivers I just looked at in 2.6.25 do unregister_netdev() followed
> sometime soon by free_netdev(). Is there something different about ATM
> devices? I did not look at all the drivers.
Indeed, this change does look bogus.
Pavel, please take a look, unregister_netdev() indeed does not free
the netdevice, and something (usually the caller) needs to do it.
I think I should revert your change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists