[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 05 May 2008 01:13:47 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: drepper@...hat.com
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
akpm@...ux-foundation.org, davidel@...ilserver.org,
mtk.manpages@...il.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH 03/18] flag parameters: paccept
From: Ulrich Drepper <drepper@...hat.com>
Date: Sun, 4 May 2008 23:42:46 -0400
> This patch is by far the most complex in the series. It adds a new syscall
> paccept. This syscall differs from accept in that it adds (at the userlevel)
> two additional parameters:
>
> - a signal mask
> - a flags value
>
> The flags parameter can be used to set flag like SOCK_CLOEXEC. This is
> imlpemented here as well. Some people argued that this is a property
> which should be inherited from the file desriptor for the server but
> this is against POSIX. Additionally, we really want the signal mask
> parameter as well (similar to pselect, ppoll, etc). So an interface
> change in inevitable.
>
> The flag value is the same as for socket and socketpair. I think
> diverging here will only create confusion. Similar to the filesystem
> interfaces where the use of the O_* constants differs, it is acceptable
> here.
>
> The signal mask is handled as for pselect etc. The mask is temporarily
> installed for the thread and removed before the call returns. I modeled
> the code after pselect. If there is a problem it's likely also in
> pselect.
...
> Signed-off-by: Ulrich Drepper <drepper@...hat.com>
Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists