netdev - Re: [RFC/T] [NET] give truesize warning when truesize differs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 May 2008 17:22:40 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC/T] [NET] give truesize warning when truesize differs

On Mon, 2008-05-05 at 23:04 +0800, Herbert Xu wrote:
> On Mon, May 05, 2008 at 03:11:20PM +0200, Johannes Berg wrote:
> >
> > >  static inline void skb_truesize_check(struct sk_buff *skb)
> > >  {
> > > -	int len = sizeof(struct sk_buff) + skb->len;
> > > +#ifdef NET_SKBUFF_DATA_USES_OFFSET
> > > +	int len = sizeof(struct sk_buff) + skb->end;
> > > +#else
> > > +	int len = sizeof(struct sk_buff) + (skb->end - skb->head);
> > > +#endif
> > 
> > Umm, is this even correct? Should it check data_len? I seem to get the
> > truesize warning a bit now:
> 
> It must check data_len.

I figured. Just add it?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)