netdev - Re: [PATCH] Remove cli()/sti() calls from HYSDN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 May 2008 10:05:17 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"M. Asselstine" <Mark.Asselstine@...driver.com>
Cc:	Karsten Keil <kkeil@...e.de>, kernel-janitors@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Remove cli()/sti() calls from HYSDN driver.

On Wed, 7 May 2008 12:25:23 -0400 "M. Asselstine" <Mark.Asselstine@...driver.com> wrote:

> On Friday 02 May 2008, Karsten Keil wrote:
> > On Thu, May 01, 2008 at 04:16:52PM -0400, Mark Asselstine wrote:
> > > >From looking at this driver the use of cli()/sti() within the do/while
> > >
> > > was a way to ensure interrupts were only disabled for short periods of
> > > time while the bulk of the time interrupts were free to occur. The
> > > use of the spin lock has eliminated the need to play with interrupts
> > > in this way while still allowing for IO to be protected.
> > >
> > > The remaining 3 sti() calls seem unneeded now that at no other point
> > > in the driver is there a call to cli().
> > >
> > > Signed-off-by: Mark Asselstine <mark.asselstine@...driver.com>
> >
> >   Acked-by: Karsten Keil <kkeil@...e.de>
> >
> Andrew, 
> 
> Would it be possible to include this commit in your tree. It is the last of 
> the cli()/sti() calls and I would love to get his work completed.

Sure, I'll take a look at it.

> The patch 
> has been vetted in kernel-janitors and netdev but no one has picked it up 
> yet. unfortunately.

I don't troll netdev for unloved patches.  A Cc:linux-kernel is often a
good idea...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html