lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 May 2008 13:06:30 -0400 From: Jeff Garzik <jgarzik@...ox.com> To: Julia Lawall <julia@...u.dk> CC: Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference Julia Lawall wrote: > On Mon, 12 May 2008, Francois Romieu wrote: > >> Julia Lawall <julia@...u.dk> : >> [...] >>> diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c >>> --- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200 >>> +++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200 >>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int >>> struct net_device *dev = (struct net_device *) dev_id; >>> >>> if (dev == NULL) { >>> - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name); >>> + printk(KERN_ERR "isr: null dev ptr\n"); >>> return IRQ_RETVAL(1); >>> } >> The lifespan of 'dev' covers the request_irq..free_irq interval in this >> driver. The whole 'dev == NULL' block can be removed. > > Will you do that? It's normal within the Linux community to give feedback on patches, and sometimes the authors need to revise their patches if helpful feedback arises. Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists