netdev - Re: [PATCH] Fix kobject_rename and !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 May 2008 02:20:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	Randy Dunlap <RANDY.DUNLAP@...CLE.COM>, Greg KH <greg@...ah.com>,
	Al Viro <viro@....linux.org.uk>,
	Benjamin Thery <benjamin.thery@...l.net>,
	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Daniel Lezcano <dlezcano@...ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	"Serge E. Hallyn" <serue@...ibm.com>, Tejun Heo <htejun@...il.com>
Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4

On Wed, 14 May 2008 02:01:37 -0700 ebiederm@...ssion.com (Eric W. Biederman) wrote:

> Andrew Morton <akpm@...ux-foundation.org> writes:
> 
> >> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> >> index 7858eac..6e61033 100644
> >> --- a/include/linux/sysfs.h
> >> +++ b/include/linux/sysfs.h
> >> @@ -20,6 +20,8 @@
> >>  struct kobject;
> >>  struct module;
> >>  
> >> +extern int kobject_set_name(struct kobject *kobj, const char *name, ...)
> >> +			    __attribute__((format(printf, 2, 3)));
> >
> > Duplicating the kobject_set_name() declaration in sysfs.h is rather a hack.
> A bit.  It really isn't worse then a struct declaration like struct kobject;
> 
> > It'd be better to move it into a new header file, included by both
> > sysfs.h and kobject.h.  Perhaps there are other declarations which can
> > be moved with it.
> 
> My gut feel says that sysfs.h should include kobject.h instead of the
> other way around.
> 
> However it gets reorganized, it is an entirely separate problem
> from the one this patch sets out to solve and so should go in
> a different patch.
> 

umm, well, actually, it's a problem which your patch introduces, by adding a
new dependency.

uninlining sysfs_rename_dir() would be a sensible solution.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html