netdev - Re: [PATCH 2/15] BE NIC driver - interrupt, ethtool, stack i/f functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 May 2008 13:49:35 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Subbu Seetharaman <subbus@...verengines.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/15] BE NIC driver - interrupt, ethtool, stack i/f functions

Subbu Seetharaman wrote:
> +static int
> +be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
> +{
> +	struct bni_net_object *pnob = netdev->priv;
> +
> +	ecmd->supported = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
> +	ecmd->advertising = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
> +	ecmd->port = PORT_FIBRE;
> +	ecmd->transceiver = XCVR_EXTERNAL;

This doesn't make a whole lot of sense.  You can't be supporting both
10GBase-T and fibre, but only ever using fibre.  If you don't know what
kind of PHY is attached, you can use MDIO to find out (or maybe query your
firmware or EEPROM).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html