netdev - Re: [PATCH 9/15] BE NIC driver - Linux system abstraction files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 May 2008 13:33:28 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Subbu Seetharaman <subbus@...verengines.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 9/15] BE NIC driver - Linux system abstraction files

Andi Kleen wrote:
> "Subbu Seetharaman" <subbus@...verengines.com> writes:
>> + */
>> +/*
>> + * system abstraction functions / macros for Linux
> 
> Sorry, pretty much this complete file has to go and the callers 
> be fixed to use the native Linux functions directly. Some of it
> was even wrong, like it's not legal to cast atomic_t like you did.
> 
> Also a lot of facilities you reimplement here exist already in Linux
> anyways under other names.

Quite agreed (speaking as net driver maintainer)

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html