netdev - Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2008 11:50:35 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Catalin Marinas" <catalin.marinas@....com>
Cc:	"Steve Glendinning" <steve.glendinning@...c.com>,
	Michael.Hennerich@...log.com,
	"Bill Gatliff" <bgat@...lgatliff.com>, netdev@...r.kernel.org,
	ian.saturley@...c.com, "Bahadir Balban" <Bahadir.Balban@....com>,
	"Dustin Mcintire" <dustin@...soria.com>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver

On Mon, May 19, 2008 at 11:45 AM, Catalin Marinas wrote:
> On Mon, 2008-05-19 at 11:27 -0400, Mike Frysinger wrote:
>> On Mon, May 19, 2008 at 8:34 AM, Steve Glendinning
>> <steve.glendinning@...c.com> wrote:
>> > +++ b/drivers/net/smsc911x.c
>> > + * History:
>> > + *   05/05/2005 bahadir.balban@....com
>> > + *     - Transition to linux coding style
>> > + *     - Platform driver and module interface
>>
>> i thought we were against this sort of changelog stuff in files.  let
>> the scm take care of the changelog.
>
> I don't have a strong opinion on whether the changelog in the file
> should be kept or not and I won't argue. However, in this particular
> instance there is no SCM log since the driver is not merged into the
> mainline kernel. When/if it is merged, this will happen as a patch
> without an SCM log.

while all true, the problem is that people who make updates in the
future often times will also update the in-file changelog

you could move the changelog out of the file and into the first commit message
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html