netdev - Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2008 20:06:58 +0100
From:	Steve.Glendinning@...c.com
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	netdev@...r.kernel.org, Ian.Saturley@...c.com
Subject: Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

Hi Catalin,

> > --- /dev/null
> > +++ b/drivers/net/smsc911x.h
> [...]
> > +/* platform_device configuration data, should be assigned to
> > + * the platform_device's dev.platform_data */
> > +struct smsc911x_platform_config {
> > +   unsigned int irq_polarity;
> > +   unsigned int irq_type;
> > +};
> 
> BTW, how could this structure be used in the platform specific code
> (arch/arm/mach-*/* in my case)? This header file cannot be included
> since it is not under the include/ directory and redefining the
> structure for each platform is prone to errors (and too much
> duplication). I can see other drivers place a header file (maybe only
> containing the structure definition) in include/linux/ or include/asm-*/
> (the latter if it is specific to only one architecture which I don't
> think it is the case here). 

Thanks Catalin, I meant to ask if this the right thing to do.

I'll keep the device register definitions in the same place and move
struct smsc911x_platform_config to a new file in include/linux/.

Regards,
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@...c.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html