netdev - Re: FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 09:02:19 +0200
From:	Brice Goglin <Brice.Goglin@...ia.fr>
To:	Dan Williams <dan.j.williams@...el.com>
CC:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>,
	davem@...emloft.net, netdev@...r.kernel.org, Brice.Goglin@...ia.fr,
	"Nelson, Shannon" <shannon.nelson@...el.com>
Subject: Re: FW: [PATCH][I/OAT]: Remove duplicate assignation in	dma_skb_copy_datagram_iovec

I don't see this patch applied anywhere, what happened to it?

Brice



Dan Williams wrote:
> Subject: net_dma: Remove duplicate assignment in dma_skb_copy_datagram_iovec
>
> From: Brice Goglin <Brice.Goglin@...ia.fr>
>
> No need to compute copy twice in the frags loop in
> dma_skb_copy_datagram_iovec().
>
> Signed-off-by: Brice Goglin <Brice.Goglin@...ia.fr>
> Acked-by: Shannon Nelson <shannon.nelson@...el.com>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
> Hi Maciej,
>
> Please be careful about maintaining attribution of the patch.
>
> Regards,
> Dan
>
>  net/core/user_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/net/core/user_dma.c b/net/core/user_dma.c
> index 0ad1cd5..c77aff9 100644
> --- a/net/core/user_dma.c
> +++ b/net/core/user_dma.c
> @@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
>  
>  		end = start + skb_shinfo(skb)->frags[i].size;
>  		copy = end - offset;
> -		if ((copy = end - offset) > 0) {
> +		if (copy > 0) {
>  			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>  			struct page *page = frag->page;
>  
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html