netdev - Re: [PATCH 1/3] bnx2: Add support for CNIC driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2008 21:52:48 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	paulmck@...ux.vnet.ibm.com
cc:	"David Miller" <davem@...emloft.net>, michaelc@...wisc.edu,
	"Anil Veerabhadrappa" <anilgv@...adcom.com>,
	netdev <netdev@...r.kernel.org>, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com
Subject: Re: [PATCH 1/3] bnx2: Add support for CNIC driver.

Paul E. McKenney wrote:

> So if a second CNIC driver attempts to register, it gets -EBUSY or
> something, right?

There is only one CNIC driver and it will only register once per
BNX2 netdevice.

> > You are right.  We should just unconditionally set up the IRQ
> > information without checking for c_ops.  The data 
> structures we set up
> > below are owned by us.
> 
> OK.  Hmmm....  You cannot even get away with sarcasm these days!  ;-)

Hmm, not sure what's the sarcasm.  The code here is trying to set up
the IRQ information so that CNIC driver can see it.  Even if the CNIC
driver is deregistering or was never registered, it doesn't hurt to
set up that information.

Anyway, I'll add some comments to the code to explain this better when
I respin.

> Very good.  Could you please add a comment to that effect?  Otherwise
> people search for what data structure is being freed up.
> 

Will do.  Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html