netdev - Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2008 14:47:29 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	"Ramachandra K" <ramachandra.kuchimanchi@...gic.com>
Cc:	netdev@...r.kernel.org, poornima.kamath@...gic.com,
	general@...ts.openfabrics.org, amar.mudrankit@...gic.com
Subject: Re: [ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.

 > The debugging code is always compiled in and is controlled
 > at run time through vnic_debug module parameter.
 > INFINIBAND_QLGC_VNIC_DEBUG config option only controls verbose debugging
 > which adds some extra information in the debug statements (file name,
 > line number)
 > which we typically use for debug builds of the driver.  Even if this option is
 > set to 'n', users can still get all debug messages from the driver by using the
 > vnic_debug module parameter.

OK, I looked at the code.  Is there any point to having
CONFIG_INFINIBAND_QLGC_VNIC_DEBUG at all??  Is anyone going to care
about having __FILE__ and __LINE__ included in the output and want to
set this option to 'n'?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html