netdev - Re: [PATCH 3/7] [CCID-3]: Remove ccid3hc{tx,rx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 May 2008 06:26:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/7] [CCID-3]: Remove ccid3hc{tx,rx}_ prefixes

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Tue, 27 May 2008 09:32:43 +0100

> This patch does the same for CCID-3 as the previous patch for CCID-2:
> 
>         s#ccid3hctx_##g;
>         s#ccid3hcrx_##g;
> 
> plus manual editing to retain consistency.
> 
> Please note: expanded the fields of the `struct tfrc_tx_info' in the hc_tx_sock,
> since using short #define identifiers is not a good idea. The only place where
> this embedded struct was used is ccid3_hc_tx_getsockopt().
> 
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>

My same comments for CCID-2 apply here, don't do this, we use
the member name prefixes to make the code easier to search
precisely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html