netdev - Re: [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when UDP socket is closed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2008 23:33:06 +0100
From:	James Chapman <jchapman@...alix.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2][L2TP]: Fix possible WARN_ON from socket code when
 UDP socket is closed

David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 04 Jun 2008 15:08:35 -0700 (PDT)
> 
>> Applied, thanks.
> 
> James your second patch doesn't apply cleanly:
> 
> @@ -1066,7 +1100,7 @@ static int pppol2tp_xmit(struct ppp_chan
>  	dst_release(skb->dst);
>  	skb->dst = dst_clone(__sk_dst_get(sk_tun));
>  	skb_orphan(skb);
> -	skb->sk = sk_tun;
> +	pppol2tp_skb_set_owner_w(skb, sk_tun);
>  
>  	/* Queue the packet to IP for output */
>  	len = skb->len;
> 
> There is no skb_orphan() call in the current pppol2tp.c code.
> 
> Please always prepare your patches against the current tree.

My apologies. I sent the wrong patch version. The skb_orphan() call was 
moved in the truesize patch that has already been applied. Shall I resend?

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html