netdev - Re: blackfin drivers/net/smc91x.c build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2008 11:37:03 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Adrian Bunk" <bunk@...nel.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Mike Frysinger" <vapier.adi@...il.com>,
	"Jeff Garzik" <jeff@...zik.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: blackfin drivers/net/smc91x.c build error

On Wed, Jun 11, 2008 at 1:34 AM, Adrian Bunk <bunk@...nel.org> wrote:
> On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
>> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
>> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>> >> > drivers/net/smc91x.c fails as follows on blackfin:
>> >> > ...
>> >> >  CC      drivers/net/smc91x.o
>> >> > ...
>> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>> >> > ...
>> >>
>> >> it's a known issue (been known for quite a long time actually).  Bryan
>> >> has brought this up in the past already.
>> >
>> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
>> > correct or how else should it be resolved?
>>
>> Bryan is taking care of it ... it may just stay broken in favor of
>> waiting for the merge from the net tree.
>>
>> > This issue is the only remaining problem preventing that all blackfin
>> > defconfigs will compile in 2.6.26...
>>
>> not really true.
>>...
>
> What other build errors do you get in Linus' tree?
>

Sorry for jumping in later. I reported this issue 2 months ago.
http://lkml.org/lkml/2008/4/7/38

And Adrian is right, we need to revert this patch.

Linus, could you please revert it?
099c736a470c8080a166e7a089f1e48e15f9947c
Or I send a patch out to revert it?

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html