netdev - Re: [PATCH net-next 11/15]bnx2x: Add TPA, Broadcoms HW LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2008 16:05:40 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Eilon Greenstein <eilong@...adcom.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Michael Chan <mchan@...adcom.com>,
	Vladislav Zolotarov <vladz@...adcom.com>
Subject: Re: [PATCH net-next 11/15]bnx2x: Add TPA, Broadcoms HW LRO

Eilon Greenstein wrote:
> The TPA stands for Transparent Packet Aggregation. When enabled, the FW
> aggregate in-order TCP packets according to the 4-tuple match and sends
> 1 big packet to the driver. This packet is stored on an SGL in which
> each SGE is 1 page. The FW also implements a timeout algorithm and it
> honors all TCP flag, including the push flag as a trigger to halt
> aggregation.
[...]

LRO is not compatible with forwarding and will currently trigger a BUG() or
WARN() if used on packets that are then forwarded.  I am about to post a
fix for that which will automatically disable LRO as necessary, but it
depends on drivers behaving properly.

TPA needs to be controllable per-device through the ethtool set_flags()
operation and should be visible in the device feature flags as NETIF_F_LRO
(and through get_flags()).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html