netdev - Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2008 21:26:10 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Subbu Seetharaman <subbus@...verengines.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

On Thu, Jun 12, 2008 at 03:40:07AM -0700, Subbu Seetharaman wrote:
> Signed-off-by: Subbu Seetharaman <subbus@...verengines.com>
> ---
>  drivers/net/benet/Makefile |   22 +
>  drivers/net/benet/bni.c    | 1177 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 1199 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/benet/Makefile
>  create mode 100644 drivers/net/benet/bni.c
> 
> diff --git a/drivers/net/benet/Makefile b/drivers/net/benet/Makefile
> new file mode 100644
> index 0000000..0fe3297
> --- /dev/null
> +++ b/drivers/net/benet/Makefile
> @@ -0,0 +1,22 @@
> +#
> +# Makefile to build the network driver for ServerEngine's BladeEngine.
> +#
> +BECLIBPATH = $(src)/../../message/beclib
> +
> +EXTRA_CFLAGS = -Wno-unknown-pragmas -DFUNCTION_NIC -I$(BECLIBPATH) \
> +	-I$(BECLIBPATH)/fw -I$(BECLIBPATH)/fw/amap -I$(BECLIBPATH)/fw/bmap 
> +
> +obj-$(CONFIG_BENET) 	:= benet.o
> +
> +benet-objs	:=  be_init.o be_int.o be_netif.o be_ethtool.o bni.o \
> +	../../message/beclib/funcobj_ll.o  \
> +	../../message/beclib/chipobj_ll.o \
> +	../../message/beclib/cq_ll.o \
> +	../../message/beclib/eq_ll.o \
> +	../../message/beclib/main_ll.o \
> +	../../message/beclib/mpu_ll.o \
> +	../../message/beclib/ethrx_ll.o \
> +	../../message/beclib/ethtx_ll.o \
> +	../../message/beclib/rxf_ll.o


I would have expected the message support to be implmented as a separate
module with a nice interface used by benet.
This would also kill the above misuse of kbuild.

No matter what you do then please use:
benet-y := be_init.o be_int.o be_netif.o be_ethtool.o ...
as replacement for benet-objs := ....

	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html