netdev - Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

Open Source and information security mailing list archives

Date:	Wed, 18 Jun 2008 10:07:00 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	John Rigby <jcrigby@...il.com>
Cc:	"Jeff Garzik" <jeff@...zik.org>,
	Scott Wood <scottwood@...escale.com>, linuxppc-dev@...abs.org,
	Sam Ravnborg <sam@...nborg.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

On Jun 17, 2008, at 11:12 PM, John Rigby wrote:

> Sorry, I thought I was doing the right thing to base the patch on  
> Kumar's patch that removes the CONFIG_PPC_CPM_NEW_BINDING stuff.   
> That is likely why it did not apply.

It is the right thing, we just need to work out the logistics here.   
Jeff, would you be willing to pull the following patch into your tree:

http://patchwork.ozlabs.org/linuxppc/patch?q=gala&filter=incoming&id=18939

(I can resend it to you if needed.  It seems better for you to have  
this patch in your tree to allow further development on the work John  
is doing)

- k

> On Tue, Jun 17, 2008 at 9:54 PM, Jeff Garzik <jeff@...zik.org> wrote:
> John Rigby wrote:
> Fixed all errors and warnings that checkpatch.pl
> reports if this was a new submission.
> Also changed instances of fec_t to struct fec in
> mac-fec.c and mii-fec.c.
>
> This is in preparation of adding MPC5121 support.
>
> Signed-off-by: John Rigby <jrigby@...escale.com>
> ---
>  drivers/net/fs_enet/fs_enet-main.c |   70 +++++++++++++++++++ 
> +---------------
>  drivers/net/fs_enet/fs_enet.h      |   15 +++++---
>  drivers/net/fs_enet/mac-fcc.c      |    7 ++--
>  drivers/net/fs_enet/mac-fec.c      |   40 ++++++++++----------
>  drivers/net/fs_enet/mac-scc.c      |   13 ++++---
>  drivers/net/fs_enet/mii-bitbang.c  |    4 +-
>  drivers/net/fs_enet/mii-fec.c      |   23 +++++++-----
>  7 files changed, 95 insertions(+), 77 deletions(-)
>
> patch does not apply
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives