lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jun 2008 20:42:43 +0300 From: "Eilon Greenstein" <eilong@...adcom.com> To: "David Miller" <davem@...emloft.net> cc: bhutchings@...arflare.com, netdev@...r.kernel.org, mchan@...adcom.com, vladz@...adcom.com Subject: Re: [PATCH net-next 11/15]bnx2x: Add TPA, Broadcoms HW LRO On Tue, 2008-06-17 at 16:16 -0700, David Miller wrote: > From: Ben Hutchings <bhutchings@...arflare.com> > Date: Tue, 17 Jun 2008 16:17:06 +0100 > > > Ben Hutchings wrote: > > > Eilon Greenstein wrote: > > > > The TPA stands for Transparent Packet Aggregation. When enabled, the FW > > > > aggregate in-order TCP packets according to the 4-tuple match and sends > > > > 1 big packet to the driver. This packet is stored on an SGL in which > > > > each SGE is 1 page. The FW also implements a timeout algorithm and it > > > > honors all TCP flag, including the push flag as a trigger to halt > > > > aggregation. > > > [...] > > > > > > LRO is not compatible with forwarding and will currently trigger a BUG() or > > > WARN() if used on packets that are then forwarded. > > > > Actually, since this implementation doesn't set gso_size in LRO'd skbs, it > > will confuse TCP in interesting ways instead. You need to set gso_size to > > the largest segment size seen in the packets that were aggregated. > > Eilon, please sort this out, thanks. Just to make sure that we are working in the right direction: we will add the ethtool support and the gso_size, but until Ben's patch will be in place, we will still fail in the same way any other LRO driver will fail in forwarding. If this is the case, I will send another patch with the ethtool and gso_size soon. Please confirm, Eilon -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists